feat: log secGemini response to /tmp/ if timesketch app mode is set to DEBUG #3562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful debugging feature to log SecGemini responses to a file when Timesketch is in DEBUG mode. My review focuses on improving the implementation's adherence to the style guide for import ordering, and more critically, enhancing the security and portability of the file-writing logic. I've suggested using standard library functions for creating temporary files securely to prevent potential vulnerabilities and ensure cross-platform compatibility.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
itsmvd
approved these changes
Nov 3, 2025
* Stream conversation directly into a file to save memory * Ensure all responses are recorded and not just the last for debugging * Store data as json where possible for easier debugging
jkppr
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Timesketch is set to DEBUG, log the responses of secgemini to a file in
/tmp/. This drastically increases ability to debug and troubleshoot interactions with the LLM backend.